Skip to content

i18n: complete Korean (ko) translation#999

Open
moduvoice wants to merge 1 commit into
ChatGPTBox-dev:masterfrom
moduvoice:i18n/complete-korean
Open

i18n: complete Korean (ko) translation#999
moduvoice wants to merge 1 commit into
ChatGPTBox-dev:masterfrom
moduvoice:i18n/complete-korean

Conversation

@moduvoice

@moduvoice moduvoice commented Jul 11, 2026

Copy link
Copy Markdown

Motivation

This completes the existing partial Korean (ko) translation — to help Korean-speaking
users use this open-source project more comfortably in their own language. The ko
locale previously covered 166/220 keys; this PR adds the remaining 54 missing keys so
ko/main.json now matches en/main.json key-for-key (220/220).

한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 기존에 부분적으로 되어 있던
한글화 작업을 완료하였습니다 (166/220 → 220/220).

Changes

  • src/_locales/ko/main.json: added the 54 keys missing relative to en/main.json
    (mostly AI provider/model-name labels such as OpenAI (GPT-4.1),
    Anthropic (Claude Opus 4.5), Azure OpenAI (API), etc., plus one UI checkbox
    label: Crop Text to ensure the input tokens do not exceed the model's limit).
  • Pure insertion — no existing keys/values were modified, per AGENTS.md's
    localization workflow ("do not change existing keys, only add new ones").
  • Brand/model names were intentionally left untranslated, consistent with existing
    ko entries (e.g. Claude.ai (Web)Claude.ai (웹): only the generic "Web" /
    "웹" wrapper is translated, product/model names are preserved verbatim).

Testing

  • Key-parity check: ko/main.json and en/main.json now have the exact same 220
    keys (verified programmatically, zero missing/extra on either side).
  • npm run lint — clean pass, no errors.
  • npm run build — clean pass (exit 0), all expected build/chromium artifacts
    produced.

Summary by CodeRabbit

  • New Features
    • Added Korean translations for additional model and provider options.
    • Added localized names for GPT and Claude model variants across supported API providers.
    • Added a Korean translation for the “Crop Text…” instruction.

ko/main.json had fallen behind en/main.json (166/220 keys). Added the
54 missing keys, mostly newer AI model-name strings (GPT-5.x/5.6
variants, Claude Opus/Sonnet/Haiku 4.x variants, Azure OpenAI, etc.)
plus one UI checkbox label. Model/provider/version names are kept
as-is per the existing ko convention (e.g. "Claude.ai (Web)" ->
"Claude.ai (웹)"); only descriptor words like "(Web)" are localized
to "(웹)". ko/main.json now has full 220/220 key parity with
en/main.json.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds Korean translations for various AI models and providers (such as ChatGPT, OpenAI, Anthropic Claude, and Azure OpenAI) to the src/_locales/ko/main.json localization file. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c92f2505-f99c-4074-ae03-364256d8d95c

📥 Commits

Reviewing files that changed from the base of the PR and between ac4a44b and ed3c470.

📒 Files selected for processing (1)
  • src/_locales/ko/main.json

📝 Walkthrough

Walkthrough

The Korean locale adds translation keys for web-mode and API-mode provider/model selection labels, covering GPT, Claude, and Azure OpenAI variants, plus a crop-text instruction.

Changes

Korean model translations

Layer / File(s) Summary
Web-mode model labels
src/_locales/ko/main.json
Adds Korean labels for ChatGPT Web, GPT-3.5, and several web-mode GPT model variants.
API-mode model labels
src/_locales/ko/main.json
Adds Korean labels for OpenAI, Anthropic, and Azure OpenAI models, along with the crop-text instruction.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: completing the Korean locale translation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

i18n: complete Korean (ko) translation key parity with English

✨ Enhancement 🕐 10-20 Minutes

Grey Divider

AI Description

• Add missing Korean locale entries to match English key-for-key.
• Fill provider/model label strings while preserving brand/model names verbatim.
• Keep i18n workflow compliant by only inserting new keys (no modifications).
Diagram

graph TD
  EN["en/main.json"] --> PARITY["Key parity check"] --> KO["ko/main.json"] --> I18N["i18n lookup"] --> UI["Provider/model UI"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Add CI/PR check for locale key parity
  • ➕ Prevents locales from silently falling behind en/main.json again
  • ➕ Automates what is currently a manual/programmatic verification step
  • ➖ Requires wiring a script into CI and maintaining it as key sources evolve
2. Generate locale skeletons from en/main.json
  • ➕ Makes it easy to propagate new keys to all locales with placeholders
  • ➕ Reduces manual diffing when new strings are introduced
  • ➖ Does not solve translation quality/completeness by itself
  • ➖ May create noisy PRs if many locales get placeholder keys

Recommendation: The PR’s approach (insertion-only additions to ko/main.json to match en/main.json) is the safest and aligns with the repo’s localization rules. Consider a follow-up to add an automated key-parity check in CI to prevent future drift across locales.

Files changed (1) +54 / -0

Enhancement (1) +54 / -0
main.jsonAdd missing Korean locale keys for provider/model labels +54/-0

Add missing Korean locale keys for provider/model labels

• Adds the previously-missing keys so ko/main.json matches en/main.json key-for-key. Includes provider/model label strings (OpenAI/Anthropic/Azure variants) and one UI checkbox label, preserving product/model names while localizing generic descriptors (e.g., “Web” → “웹”).

src/_locales/ko/main.json

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@kilo-code-bot

kilo-code-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • src/_locales/ko/main.json - 54 keys added; full 220/220 key parity with en/main.json

Verification performed

  • JSON validity: both ko/main.json and en/main.json parse cleanly with jq empty.
  • Key parity: ko and en each contain exactly 220 keys with an identical key set (zero missing/extra on either side).
  • Duplicate keys: 220 raw key lines == 220 deduped keys, so no duplicate-key JSON defects.
  • Translation convention: 53 of the 54 new entries are AI provider/model names left verbatim (value == key), consistent with the existing ko convention; only the UI checkbox label Crop Text to ensure the input tokens do not exceed the model's limit is actually translated, and its Korean value is a correct, grammatically sound translation.
  • No existing keys or values were modified (pure insertion), per the localization workflow.

Reviewed by hy3-20260706:free · Input: 98.7K · Output: 13.6K · Cached: 1M

@PeterDaveHello PeterDaveHello requested a review from Copilot July 12, 2026 14:17
@PeterDaveHello

Copy link
Copy Markdown
Member

@codex review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Completes the Korean (ko) localization by adding the remaining missing strings so src/_locales/ko/main.json matches en/main.json key-for-key, improving the browser extension’s UI coverage for Korean-speaking users.

Changes:

  • Added missing provider/model label strings (e.g., OpenAI/Anthropic/Azure OpenAI variants) to the Korean locale.
  • Added Korean translation for the “Crop Text…” UI label.
  • Kept keys aligned with en/main.json ordering and avoided modifying existing keys/values (pure insertion).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/_locales/ko/main.json
"OpenAI (GPT-3.5-turbo)": "OpenAI (GPT-3.5-turbo)",
"ChatGPT (GPT-4-8k)": "ChatGPT (GPT-4-8k)",
"OpenAI (GPT-4-8k)": "OpenAI (GPT-4-8k)",
"ChatGPT (GPT-4-32k)": "ChatGPT (GPT-4-32k)",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove those that are identical to English to minimize maintenance effort here. Thanks.

Reference: #984

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: ed3c47078a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants