Skip to content

Add OpenAI GPT-5.6 alias and tiered model presets#997

Merged
PeterDaveHello merged 1 commit into
ChatGPTBox-dev:masterfrom
PeterDaveHello:add-gpt-56-models
Jul 9, 2026
Merged

Add OpenAI GPT-5.6 alias and tiered model presets#997
PeterDaveHello merged 1 commit into
ChatGPTBox-dev:masterfrom
PeterDaveHello:add-gpt-56-models

Conversation

@PeterDaveHello

@PeterDaveHello PeterDaveHello commented Jul 9, 2026

Copy link
Copy Markdown
Member

Expose the documented alias alongside explicit tiers so users can choose either the stable family entry or a named tier.

Reference:

Summary by CodeRabbit

  • New Features

    • Added support for new OpenAI GPT-5.6 model options, including Sol, Terra, and Luna variants.
    • Updated model labels in the provider selection UI so these options display correctly.
  • Bug Fixes

    • Improved compatibility checks so the new GPT-5.6 models use the expected token parameter behavior.
    • Expanded validation coverage to help ensure model name translations continue to resolve to the right display text.

@PeterDaveHello
PeterDaveHello requested a review from Copilot July 9, 2026 18:50
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d20a3b7e-cf5b-4044-aab1-eb02629d0013

📥 Commits

Reviewing files that changed from the base of the PR and between ff3d5f7 and 5ba682c.

📒 Files selected for processing (5)
  • src/_locales/en/main.json
  • src/config/index.mjs
  • tests/unit/config/config-predicates.test.mjs
  • tests/unit/services/apis/openai-token-params.test.mjs
  • tests/unit/utils/model-name-convert.test.mjs

📝 Walkthrough

Walkthrough

This PR adds four new OpenAI GPT-5.6 model variants (base, Sol, Terra, Luna) to the configuration's chatgptApiModelKeys and Models mappings, adds corresponding English locale entries, and extends existing unit tests for config predicates, token parameters, and model name conversion to cover the new keys.

Changes

GPT-5.6 Model Support

Layer / File(s) Summary
Config and locale additions
src/config/index.mjs, src/_locales/en/main.json
Adds chatgptApi5_6, chatgptApi5_6Sol, chatgptApi5_6Terra, chatgptApi5_6Luna to chatgptApiModelKeys and Models with value/desc fields, plus matching English locale strings.
Unit test coverage
tests/unit/config/config-predicates.test.mjs, tests/unit/services/apis/openai-token-params.test.mjs, tests/unit/utils/model-name-convert.test.mjs
Extends representativeChatgptApiModelNames, the max_completion_tokens model list, and modelNameToDesc assertions to cover the new GPT-5.6 variants.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: Review effort 2/5

Suggested reviewers: kmk142789

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: adding the OpenAI GPT-5.6 alias and tiered model presets.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Add OpenAI GPT-5.6 alias and Sol/Terra/Luna model presets

✨ Enhancement 🧪 Tests ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Add GPT-5.6 stable alias plus Sol/Terra/Luna tier presets to model registry.
• Expose new model display strings in English locale for UI selection.
• Extend unit tests to cover new model keys, descriptions, and token param behavior.
Diagram

graph TD
  UI["Model picker UI"] --> I18N["en locale strings"] --> CFG["Models registry"] --> API["OpenAI token params"]
  CFG --> UTIL["modelNameToDesc()"]
  TESTS["Unit tests"] --> CFG --> UTIL
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Data-driven model registry + derived test coverage
  • ➕ Reduces repetitive updates across config, locale keys, and multiple test lists
  • ➕ Makes it harder to forget adding a new model to one of the representative arrays
  • ➖ Higher up-front refactor cost for a simple additive change
  • ➖ May complicate explicit ordering/presentation logic if the UI relies on curated lists
2. Auto-generate locale model labels from model IDs
  • ➕ Eliminates duplication between i18n strings and model registry descriptions
  • ➖ Harder to localize non-English strings later if labels are no longer explicit i18n entries
  • ➖ May produce less polished names (capitalization/tier naming) without manual curation

Recommendation: The PR’s explicit additions are consistent with the existing pattern and are appropriate for a small change. If model tiers continue to expand frequently, consider a follow-up to centralize preset definitions and derive representative test lists (and possibly UI labels) from that single source to avoid drift.

Files changed (5) +24 / -0

Enhancement (1) +8 / -0
index.mjsRegister GPT-5.6 alias and Sol/Terra/Luna presets in model config +8/-0

Register GPT-5.6 alias and Sol/Terra/Luna presets in model config

• Extends the ChatGPT API model key list and the Models registry with entries for gpt-5.6 and the gpt-5.6-sol/terra/luna tiers, each mapped to a user-facing description.

src/config/index.mjs

Tests (3) +12 / -0
config-predicates.test.mjsInclude GPT-5.6 presets in representative ChatGPT model key tests +4/-0

Include GPT-5.6 presets in representative ChatGPT model key tests

• Adds the new GPT-5.6 model keys to the representative model name list so predicate/config coverage includes the new presets.

tests/unit/config/config-predicates.test.mjs

openai-token-params.test.mjsValidate token parameter handling for GPT-5.6 model names +4/-0

Validate token parameter handling for GPT-5.6 model names

• Extends the recent gpt-5.x model-name test set to include gpt-5.6 and the new tiered variants, ensuring max_completion_tokens is used consistently.

tests/unit/services/apis/openai-token-params.test.mjs

model-name-convert.test.mjsVerify modelNameToDesc mappings for GPT-5.6 presets +4/-0

Verify modelNameToDesc mappings for GPT-5.6 presets

• Adds assertions that the new internal preset keys resolve to the expected display descriptions for GPT-5.6, Sol, Terra, and Luna.

tests/unit/utils/model-name-convert.test.mjs

Other (1) +4 / -0
main.jsonAdd English display strings for GPT-5.6 and tiered presets +4/-0

Add English display strings for GPT-5.6 and tiered presets

• Adds new locale entries for "OpenAI (GPT-5.6)" plus the Sol/Terra/Luna tier names so they appear correctly in the UI.

src/_locales/en/main.json

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the new OpenAI GPT-5.6 models (including the Sol, Terra, and Luna variants) by updating the localization files, model configurations, and unit tests. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates ChatGPTBox’s OpenAI (API) model presets to include the GPT‑5.6 family, exposing both the documented base alias (gpt-5.6) and the tiered variants (Sol/Terra/Luna) so they appear correctly in the UI and remain covered by existing model-name and token-parameter behaviors.

Changes:

  • Added GPT‑5.6 preset keys to the OpenAI (API) model list and Models registry.
  • Added English i18n labels for the new GPT‑5.6 presets.
  • Expanded unit tests to cover model-name descriptions, config predicates, and token parameter selection for the new model IDs.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/unit/utils/model-name-convert.test.mjs Extends modelNameToDesc coverage for GPT‑5.6 + tier variants.
tests/unit/services/apis/openai-token-params.test.mjs Ensures GPT‑5.6 model IDs use max_completion_tokens behavior.
tests/unit/config/config-predicates.test.mjs Updates representative ChatGPT API model keys to include GPT‑5.6 presets.
src/config/index.mjs Registers GPT‑5.6 presets in chatgptApiModelKeys and Models for UI/config usage.
src/_locales/en/main.json Adds English strings for new GPT‑5.6 preset labels.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kilo-code-bot

kilo-code-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (5 files)
  • src/_locales/en/main.json
  • src/config/index.mjs
  • tests/unit/config/config-predicates.test.mjs
  • tests/unit/services/apis/openai-token-params.test.mjs
  • tests/unit/utils/model-name-convert.test.mjs

Reviewed by step-3.7-flash-20260528 · Input: 303.8K · Output: 7.9K · Cached: 484.2K

@PeterDaveHello
PeterDaveHello merged commit 2de2f04 into ChatGPTBox-dev:master Jul 9, 2026
4 checks passed
@PeterDaveHello
PeterDaveHello deleted the add-gpt-56-models branch July 9, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants