Fix: Incorrect and inconsistent cell type in nangate45 library - #20
Open
AstroGD wants to merge 1 commit into
Open
Fix: Incorrect and inconsistent cell type in nangate45 library#20AstroGD wants to merge 1 commit into
AstroGD wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/ChairImpSec/PROLEAD/blob/main/libs/nang45.json correctly sets cell types for the nangate45 library to work with the robust but relaxed probing model.
However, https://github.com/ChairImpSec/PROLEAD/blob/main/library.json, the default library used by PROLEAD, has incorrect cell types and differs from the
libs/nang45.jsonfile.This creates incorrect (false-positive) leakage results by default with, for example, CCHPC gadgets.
I propose to use the settings from
libs/nang45.jsonin thelibrary.jsonas well.Attention before merging: Issue #19 needs to be resolved first or the default library will be rendered unusable.