fix(build): wasteful go ffi tests rebuild - #7466
Conversation
WalkthroughThe interop test build script no longer regenerates ChangesGo FFI regeneration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@interop-tests/build.rs`:
- Around line 12-18: Add a CI step for the interop tests that enables the
regeneration configuration in build.rs and compares the regenerated ffi_gen.go
with the committed version, failing when they differ. Use the existing
rust2go::RegenArgs source and destination symbols, and keep normal builds
unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 73735eaa-40f3-44a0-8184-7ebba7383fd2
📒 Files selected for processing (1)
interop-tests/build.rs
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
filecoin-project/lotus(manual)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 9 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Summary of changes
Changes introduced in this pull request:
cargo nextest...takes around a minute to rebuild (most likely linking) even though NOTHING changed. With this change, consecutivecargo nextest...runs just run the tests without any hold-up.forest/build.rs
Lines 37 to 44 in 9199a82
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit