Skip to content

fix: block-disable set-state-in-effect in useEffect body #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Aug 3, 2026
Merged

fix: block-disable set-state-in-effect in useEffect body #1744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/time-series-chart/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,15 +410,16 @@
const has1y = !panelActive && lazySeries1y !== null && Object.keys(lazySeries1y).length > 0;

// When confirmed-empty data comes back, fall back to the nearest longer available range.
// eslint-disable-next-line react-hooks/set-state-in-effect
useEffect(() => {
if (panelActive) return;
/* eslint-disable react-hooks/set-state-in-effect */
if (range === "7d" && lazySeries7d !== null && !seriesHasData(lazySeries7d)) setRange("24h");
if (range === "30d" && lazySeries30d !== null && !seriesHasData(lazySeries30d)) setRange("24h");
if (range === "90d" && lazySeries90d !== null && Object.keys(lazySeries90d).length === 0)
setRange(has30d ? "30d" : "24h");
if (range === "1y" && lazySeries1y !== null && Object.keys(lazySeries1y).length === 0)
setRange(has90d ? "90d" : "24h");
/* eslint-enable react-hooks/set-state-in-effect */
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [range, panelActive, lazySeries7d, lazySeries30d, lazySeries90d, lazySeries1y]);

Expand Down Expand Up @@ -540,7 +541,7 @@
return higherIsBetter ? bv - av : av - bv;
});
return built;
}, [benchmark, range, region, colors, excluded, seriesOverride, seriesOverride7d, seriesOverride30d, higherIsBetterOverride, lazySeries7d, lazySeries30d, lazySeries90d, lazySeries1y, isLongRange, longRangeSeries, panelLazy90d, panelLazy1y]);

Check warning on line 544 in src/components/time-series-chart/index.tsx

View workflow job for this annotation

GitHub Actions / check 

React Hook useMemo has missing dependencies: 'panelLazy30d' and 'panelLazy7d'. Either include them or remove the dependency array

// Top-N selector — sized off the post-filter line count via the
// shared `useTopN` hook so the option set agrees across every
Expand Down
Loading