Dynamic fuel switching #121 - #154
Open
urwahah wants to merge 3 commits into
Open
Conversation
urwahah
commented
Aug 18, 2026
| "NG_mode", | ||
| ], | ||
| axis=1, | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
i don't love this logic of dropping columns afterward (just because i think it's unnecessary info to output), it might be nicer to call the finalize_columns function here instead of in loads_to_site. but this would mean moving the detail parameter and some small restructuring. i actually think this would be good regardless because a lot of the columns needed in site_to_source are not in the base columns defined in finalize_columns so the calculation would break if detail is ever set to False. also it's just a little annoying to have to list every column passed between loads_to_site and site_to_source.. let me know what you think!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #121:
loads_to_sitedataframe:site_to_sourcesite_to_sourceHere is a link to the change request to update docs for this.
A few minor changes unrelated to the fuel switching: