Add activity-generated air speed toggle and fix adaptive comfort chart boundaries#93
Add activity-generated air speed toggle and fix adaptive comfort chart boundaries#93t-kramer wants to merge 2 commits intodevelopmentfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@FedericoTartarini Please review and merge into |
Summary
This PR introduces a user-facing toggle to control whether activity-generated (relative) air
speed is included in PMV calculations.
Relative air speed toggle
ASHRAE 55 requires adding a self-generated air speed component (v + 0.3 × (met − 1) when met > 1
met) to the measured air speed. This is appropriate for occupants walking, but not for people at
elevated metabolic rates without generating air movement (e.g. exercising on stationary
equipment).
A new "Relative air speed" button has been added to the button group at the bottom of the input
panel on the ASHRAE, EN 16798, Compare, and Ranges tabs (Fans & Heat and PHS are unaffected as
they do not use relative air speed). Clicking the button opens a modal dialog explaining the
feature, with a checkbox to enable or disable it.
When enabled (default), the tool adds the activity-generated component as before. When disabled,
only the measured air speed is used. Toggling the checkbox immediately recalculates and redraws
all outputs.
A display note — "Relative air speed = X m/s" — appears near the chart when relative air speed is
actively applied (met > 1 and toggle enabled), matching the existing dynamic clothing display on
ASHRAE/EN.
The underlying flag (comf.useSelfGeneratedAirSpeed) is added to comfort-models.js alongside the
existing comf.relativeAirSpeed() helper.