Skip to content

Add activity-generated air speed toggle and fix adaptive comfort chart boundaries#93

Open
t-kramer wants to merge 2 commits intodevelopmentfrom
v-relative-fix
Open

Add activity-generated air speed toggle and fix adaptive comfort chart boundaries#93
t-kramer wants to merge 2 commits intodevelopmentfrom
v-relative-fix

Conversation

@t-kramer
Copy link
Copy Markdown
Contributor

@t-kramer t-kramer commented May 6, 2026

Summary

This PR introduces a user-facing toggle to control whether activity-generated (relative) air
speed is included in PMV calculations.


Relative air speed toggle

ASHRAE 55 requires adding a self-generated air speed component (v + 0.3 × (met − 1) when met > 1
met) to the measured air speed. This is appropriate for occupants walking, but not for people at
elevated metabolic rates without generating air movement (e.g. exercising on stationary
equipment).

A new "Relative air speed" button has been added to the button group at the bottom of the input
panel on the ASHRAE, EN 16798, Compare, and Ranges tabs (Fans & Heat and PHS are unaffected as
they do not use relative air speed). Clicking the button opens a modal dialog explaining the
feature, with a checkbox to enable or disable it.

When enabled (default), the tool adds the activity-generated component as before. When disabled,
only the measured air speed is used. Toggling the checkbox immediately recalculates and redraws
all outputs.

A display note — "Relative air speed = X m/s" — appears near the chart when relative air speed is
actively applied (met > 1 and toggle enabled), matching the existing dynamic clothing display on
ASHRAE/EN.

The underlying flag (comf.useSelfGeneratedAirSpeed) is added to comfort-models.js alongside the
existing comf.relativeAirSpeed() helper.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c6cf92cb-93ce-4383-bcdd-35eeecdae05b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch v-relative-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@t-kramer t-kramer requested a review from FedericoTartarini May 6, 2026 17:37
@t-kramer
Copy link
Copy Markdown
Contributor Author

t-kramer commented May 6, 2026

@FedericoTartarini Please review and merge into master if approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant