[ENG-12215] Some sentry messages / error logs should also inform PO via email - #11934
Open
Ostap-Zherebetskyi wants to merge 2 commits into
Conversation
Ostap-Zherebetskyi
marked this pull request as ready for review
September 22, 2026 13:12
antkryt
reviewed
Sep 23, 2026
Comment on lines
+312
to
+317
| if campaign.status == NotificationCampaignStatus.CANCELLED: | ||
| message = f'[Notification Campaign #{campaign_id}] WARNING: Campaign {campaign.name} was cancelled.' | ||
| logger.info(message) | ||
| sentry.log_message(message) | ||
| self.finish_campaign(campaign) | ||
| return |
Contributor
There was a problem hiding this comment.
After discussing it with Ostap, we need to decide what to do about campaign stats sync
antkryt
approved these changes
Sep 23, 2026
antkryt
left a comment
antkryt
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but we need to decide what do we do with campaign stats (not related to this ticket)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Some sentry messages / error logs should also inform PO via email
Changes
Side Effects
QE Notes
CE Notes
Documentation