[ENG-10028] SHARE is not consistently indexing OSF content#11671
[ENG-10028] SHARE is not consistently indexing OSF content#11671adlius merged 2 commits intoCenterForOpenScience:feature/pbs-26-6from
Conversation
adlius
left a comment
adlius
left a comment
There was a problem hiding this comment.
One comment and some questions.
| recatalog(queryset, start_id, chunk_count, chunk_size) | ||
|
|
||
|
|
||
| def get_not_indexed_guids_for_resource_with_no_indexed_guid(resource_type: str, first_guid: bool = True): |
There was a problem hiding this comment.
The naming of the argument first_guid could be a bit more descriptive. How about something like only_oldest_guid?
| def mark_indexing_failed(self): | ||
| self.has_been_indexed = False | ||
| from addons.osfstorage.models import OsfStorageFile | ||
| if isinstance(self, OsfStorageFile): |
There was a problem hiding this comment.
Why doe we need special casing for OstStorageFile?
There was a problem hiding this comment.
There is a recursion (another share update task is called) on save for files , such a way to avoid it
| has_been_indexed = models.BooleanField(default=None, null=True, blank=True, db_index=True) | ||
| date_last_indexed = models.DateTimeField(null=True, blank=True) |
There was a problem hiding this comment.
Does it mean these two fields would only be populated for the objects that are indexed after this PR is released? What happen to the objects that were indexed before this PR is merged/released?
There was a problem hiding this comment.
As I understand old records will be reindexed too using management command with cloud help to not left None fields for the objects.
adlius
merged commit dcb6bd4
into
CenterForOpenScience:feature/pbs-26-6
2 participants
Ticket
Purpose
Content on the OSF is not consistently being SHARE indexed. Newly created content on the OSF does not seem to be consistently being automatically indexed in SHARE, some content seems to be indexed but other content is not. There does not seem to be any way to discern what content has been indexed vs not indexed . The inability of some content to be re-indexed in admin, this is causing significant issues for OSF users, their content is not Discoverable on the OSF.
Changes
Take code from the PR
#11631 to avoid so much merge conflicts to solve with new
pbs-26-6target branchSide Effects
QE Notes
CE Notes
Documentation