fix: honor IDE allowed origins for IDE routes#162
Open
haosenwang1018 wants to merge 2 commits intoCaviraOSS:mainfrom
Open
fix: honor IDE allowed origins for IDE routes#162haosenwang1018 wants to merge 2 commits intoCaviraOSS:mainfrom
haosenwang1018 wants to merge 2 commits intoCaviraOSS:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OM_IDE_ALLOWED_ORIGINSinto the server CORS handling for/api/ide/*routesOM_IDE_MODE=trueand the origin is explicitly allowlistedWhy
Issue #123 reports that OpenMemory does not work with Claude in Antigravity.
While tracing the IDE/MCP integration path, I found that:
OM_IDE_MODEandOM_IDE_ALLOWED_ORIGINSare defined in configide_allowed_originswas never actually consumed by the serverAccess-Control-Allow-Origin: *This patch makes the IDE-specific allowlist configuration live for
/api/ide/*requests instead of leaving it as a dead config knob.Testing
cd packages/openmemory-js && npm run buildRelated to #123