build condition stack once per experiment#3238
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes within-subject experiment assignment by precomputing the (potentially expensive) ordered condition/factor queue once per experiment+user and reusing it across all decision points, rather than rebuilding the queue per decision point.
Changes:
- Adds a helper to precompute within-subject ordered conditions/factors once per experiment+user.
- Adds a helper to apply decision-point-specific payloads from a prebuilt lookup map to the precomputed ordering.
- Updates experiment assignment mapping to reuse the precomputed ordering and payload lookup across decision points.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/backend/src/api/services/ExperimentAssignmentService.ts | Precomputes within-subject condition ordering + payload lookup once, then reuses for each decision point. |
| packages/backend/src/api/Algorithms.ts | Introduces new helper functions to precompute within-subject ordering and then apply decision-point payloads efficiently. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+239
to
+243
| /** | ||
| * Applies decision-point-specific payloads to a pre-computed within-subjects condition order | ||
| * and returns the final assignment for one decision point. Pair with | ||
| * buildWithinSubjectOrderedConditions + a conditionPayloadMap built once per experiment. | ||
| */ |
Collaborator
There was a problem hiding this comment.
i think this is right, i don't know if there's going to be a need for it?
danoswaltCL
previously approved these changes
Jul 21, 2026
danoswaltCL
left a comment
danoswaltCL
left a comment
Collaborator
There was a problem hiding this comment.
this looks good to me, just piggybacking on the copilot comment that we don't really need to keep the old implementation method around if it's unused now?
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
danoswaltCL
self-requested a review
July 21, 2026 17:06
danoswaltCL
previously approved these changes
Jul 21, 2026
danoswaltCL
self-requested a review
July 21, 2026 17:19
danoswaltCL
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.