fix(infra): remove broken wget healthcheck override for media-server#2004
Open
sgsimpson wants to merge 1 commit into
Open
fix(infra): remove broken wget healthcheck override for media-server#2004sgsimpson wants to merge 1 commit into
sgsimpson wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cap-media-serverreports unhealthy in every docker-compose based deployment (docker-compose.yml,docker-compose.coolify.yml,docker-compose.template.yml), even though the service itself is fully functional. Querying/healthdirectly (e.g. from another container on the same network) returns:{"status":"ok","mediaEngine":{"available":true,...},"ffmpeg":{"available":true,...}}Root cause
The compose
healthcheck:formedia-servershells out towget:but
apps/media-server/DockerfileisFROM oven/bun:1, which never installswget. Every healthcheck invocation fails immediately:This permanently marks the container unhealthy regardless of actual application state — including for anything downstream that keys off container health (
depends_on: condition: service_healthy, monitoring/alerting, etc.).The Dockerfile already defines a correct healthcheck:
but Compose's
healthcheck:stanza overrides the image's built-inHEALTHCHECKrather than falling back to it, so this correct check never runs for anyone deploying via any of the three compose files.Fix
Remove the redundant, broken
healthcheck:override formedia-serverfrom all three compose files, so each deployment inherits the image's own correctHEALTHCHECKinstead of duplicating (and silently breaking) the same logic in three places.Testing
Applied this change against a running self-hosted instance and recreated the
media-servercontainer:Confirmed healthy and stable over multiple check intervals (
FailingStreak: 0), with no other Cap services affected.Greptile Summary
This PR lets the media server use its image-defined healthcheck. The main changes are:
wgethealthcheck override fromdocker-compose.yml.docker-compose.coolify.yml.docker-compose.template.yml.Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
wgetcheck.Reviews (1): Last reviewed commit: "fix(infra): remove broken wget healthche..." | Re-trigger Greptile
Context used: