chore: remove bash core handler + rename tempfile prefixes (#47, #60)#68
Merged
Conversation
Phase 3 of #47 is complete for all four backends, so the historical out-of-process bash orchestrator is no longer reachable. Deletes bin/core-pre-tool.sh, bin/core-post-tool.sh, and the bash-only test tests/core/test_post_tool_patch_paths.sh (coverage moved to tests/plugin/post_tool_handle_spec.lua). Removes the now-empty tests/core/ directory and the "core" filter in tests/run.sh. Renames the proposal tempfile prefixes from /tmp/claude-{diff,patch}-* to /tmp/code-preview-{diff,patch}-* (#60). The startup sweep in pre_tool.sweep_leftover_tempfiles continues to match the legacy prefixes transitionally so leftover files from pre-upgrade nvim sessions still get cleaned up; drop the legacy patterns in v1.2. Also refreshes stale comments in lua/ that still referenced the deleted shell scripts. ADRs are left as-is (canonical history). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- CONTEXT.md: update Source path example to /tmp/code-preview-diff-* (was still showing the old /tmp/claude-diff-* prefix); also <pid> → <id> since the in-process flow uses hrtime+counter rather than $$. - pre_tool/init.lua: replace the misnamed "v1.2" target in the transitional sweep comment with version-agnostic wording. Latest tag is v2.2.0, so the v1.2 reference would have made the bridge never run in production. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/core-pre-tool.sh,bin/core-post-tool.sh, and the bash-only testtests/core/test_post_tool_patch_paths.sh(coverage already lives intests/plugin/post_tool_handle_spec.lua). Remove the emptytests/core/directory and thecorefilter intests/run.sh./tmp/claude-{diff,patch}-*to/tmp/code-preview-{diff,patch}-*(Rename /tmp/claude-diff-* tempfiles to /tmp/code-preview-* #60).pre_tool.sweep_leftover_tempfilesmatches both prefixes transitionally so leftover files from pre-upgrade Neovim sessions still get cleaned up; legacy patterns to be dropped in v1.2.lua/that still referenced the deleted shell scripts. Flip the CONTEXT.md "Core handler" entry to past tense; ADR-0005 remains the canonical history.Test plan
./tests/run_lua.sh— all plenary suites green./tests/run.sh— all 65 backend + plugin tests green/tmp/claude-diff-*and new/tmp/code-preview-diff-*aftersetup()in a long-running NeovimCloses the cleanup portion of #47 phase 3. #60 is also addressed here. #64 items (looks_like_path on rm; per-proposal tempfile tracking) are intentionally out of scope.
🤖 Generated with Claude Code