Skip to content

fixed problem where objects could be added with incorrect identifiers#144

Open
InternetAstronaut wants to merge 2 commits into
Candlestickers:developmentfrom
InternetAstronaut:wick.base-fix
Open

fixed problem where objects could be added with incorrect identifiers#144
InternetAstronaut wants to merge 2 commits into
Candlestickers:developmentfrom
InternetAstronaut:wick.base-fix

Conversation

@InternetAstronaut

Copy link
Copy Markdown

This commit fixes #142. Go to the mentioned issue for clarification.

Signed-off-by: InternetAstronaut <87543901+InternetAstronaut@users.noreply.github.com>

@BaronAWC BaronAWC left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting an error whenever I try to add a wickobject to a canvas.

Image

@InternetAstronaut

Copy link
Copy Markdown
Author

Getting an error whenever I try to add a wickobject to a canvas.

Image

I think I know why. _getUniqueIdentifiers() recursively calls itself on the children of the Wick.Base object, so eventually the call stack will burst if there's too many items.

I think I'll make some quick changes!

@InternetAstronaut

Copy link
Copy Markdown
Author

Should be fixed with commit 5c6d9e5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] when adding a wickobj to a canvas, it bypasses the duplicate name detection

2 participants