FIREFLY-2107: Fix DCE SASS: Add New Chart Dialog Fails to Load Column Values - #2019
Merged
Merged
Conversation
…Processor response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FIREFLY-2107
StatisticsProcessorbatches min/max/count for all numeric columns in one SQL query, so a single array-typed column (e.g. SASS Spectra'scoord_obswithdouble[]type) failed the whole query, zeroing outcolValStatsand leaving chart X/Y axis options empty. Excluded array-type columns via!col.isArrayType()alongsideisNumeric().Testing
https://firefly-2107-sass-dce-bug.irsakubedev.ipac.caltech.edu/firefly/
Follow the instructions in ticket, the bug should be fixed. Note: this bug was also in "Chart options" dialog besides "Add new chart" dialog since they both use same components.