Conversation
robyww
force-pushed
the
FIREFLY-2118-galactic-col
branch
from
September 22, 2026 15:11
3510a3e to
2e7f1b7
Compare
robyww
changed the title
robyww
marked this pull request as ready for review
September 22, 2026 15:44
aventura121
requested changes
Sep 22, 2026
Comment on lines
321
to
333
| getCenterColumnsOnUCD() { | ||
| this.centerColumnsInfo = null; | ||
|
|
||
| const colPairs = this.getCenterColumnPairsOnUCD(UCDCoord.eq.key); | ||
|
|
||
| if (colPairs && colPairs.length === 1) { | ||
| return this.setCenterColumnsInfo(colPairs[0], posCol[UCDCoord.eq.key].coord); | ||
| } else { | ||
| this.centerColumnCandidatePairs = colPairs; | ||
| } | ||
|
|
||
| return this.centerColumnsInfo; | ||
| } |
Contributor
There was a problem hiding this comment.
I think this code remains problematic, because it hard codes UCDCoord.eq.key on line 324 and then sets that key on 327, rather than checking for each of the frames of reference; meaning we can fall into the guesser when we don't need to. There's some code elsewhere that does something similar, though I think it would need to be tweaked to fit here, but the idea of checking all of them is present: https://github.com/Caltech-IPAC/firefly/blob/dev/src/firefly/js/voAnalyzer/ColumnsModelInfo.js#L135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-2118: Column coordinate guesser is not using UCDs
Testing