Open
Conversation
- add pathPrefix to helm chart livenessProbe path when set
robyww
approved these changes
Apr 14, 2026
Contributor
robyww
left a comment
robyww
left a comment
There was a problem hiding this comment.
It all look good.
I guess it is OK we go to auto-scaling but I have several concerns. We need to dedicate a meeting to it soon.
| f"-XX:MaxRAMPercentage={os.getenv('MAX_RAM_PERCENT', '80')}", | ||
| "-XX:+UnlockExperimentalVMOptions", | ||
| "-XX:TrimNativeHeapInterval=30000", | ||
| "-XX:+UseZGC", |
Contributor
There was a problem hiding this comment.
I have not been keeping with gc's. I am glad you noticed this.
| @@ -0,0 +1,37 @@ | |||
| {{- if .Values.autoscaling.enabled }} | |||
| apiVersion: autoscaling/v2 | |||
| kind: HorizontalPodAutoscaler | |||
Contributor
There was a problem hiding this comment.
I would like to understand this. I think I would like to discuss a general concern about pod scaling and losing cache.
I am particularly concerned about long term cache like HiPS or big images like are more common now.
If pod are coming and going it defeats our caching. Should we do more caching outside of the pod?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1939
The bug described in the ticket is no longer reproducible, but the changes still make sense. We just need to perform regression testing.
Test: https://fireflydev.ipac.caltech.edu/firefly-1939-tap-schema-unquoted/firefly/
The other update includes adding autoscaling to the Helm chart and revamping the Helm documentation.
Please review the docs: https://github.com/Caltech-IPAC/firefly/tree/FIREFLY-1939-tap-schema-unquoted/helm#readme