Remove remindme functionality - #825
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
The beauty of separate cogs where whole functionality can be removed so quickly! |
CarrotManMatt
left a comment
There was a problem hiding this comment.
Sorry I approved without thinking. Can the DB functionality be soft-deprecated in some way? So that the models still exist and the DB doesn't become corrupted, but the functionality cannot be used or new data cannot be created. The DiscordReminder model is the problem here.
I mean I suppose I could try but is it worth it? it'd leave a mess in the codebase for something that realistically wouldn't give anyone any benefit? I actually forgot about the db models, so in theory that's the situation we have now right? the models still exist but the ability to modify them would be gone? This does remind me I do also need to remove the delete-all-reminders command too though so I'll do that now. |
|
Ah I think the best bet is to just mark the DB class with https://typing.python.org/en/latest/spec/directives.html#deprecated |
Which class? the commands cog? |
|
Sorry, |
CarrotManMatt
left a comment
There was a problem hiding this comment.
I suggest a note is added to the corresponding element (delete_all_reminders) in TeXBotBaseCog.ERROR_ACTIVITIES to mention that the command has been removed. But still leave the message existing in the dictionary just in case that key appears during an exception handling for some wild reason.
TeX-Bot-Py-V2/utils/tex_bot_base_cog.py
Lines 38 to 40 in 8d28d61
done |
As discussed on the CSS Discord server (and approved by committee),
/remind-mefunctionality is covered by other existing bots and so can be removed.