Skip to content

Remove remindme functionality - #825

Open
MattyTheHacker wants to merge 7 commits into
mainfrom
yeet-remindme
Open

Remove remindme functionality#825
MattyTheHacker wants to merge 7 commits into
mainfrom
yeet-remindme

Conversation

@MattyTheHacker

@MattyTheHacker MattyTheHacker commented Aug 22, 2026

Copy link
Copy Markdown
Member

As discussed on the CSS Discord server (and approved by committee), /remind-me functionality is covered by other existing bots and so can be removed.

@MattyTheHacker MattyTheHacker self-assigned this Aug 22, 2026
@MattyTheHacker
MattyTheHacker requested review from a team and a lite review from Copilot August 22, 2026 23:05
@MattyTheHacker MattyTheHacker added the sync Request bots to automatically keep this PR up to date with it's base branch label Aug 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@CarrotManMatt

Copy link
Copy Markdown
Member

The beauty of separate cogs where whole functionality can be removed so quickly!

@CarrotManMatt CarrotManMatt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I approved without thinking. Can the DB functionality be soft-deprecated in some way? So that the models still exist and the DB doesn't become corrupted, but the functionality cannot be used or new data cannot be created. The DiscordReminder model is the problem here.

@MattyTheHacker

Copy link
Copy Markdown
Member Author

Sorry I approved without thinking. Can the DB functionality be soft-deprecated in some way? So that the models still exist and the DB doesn't become corrupted, but the functionality cannot be used or new data cannot be created. The DiscordReminder model is the problem here.

I mean I suppose I could try but is it worth it? it'd leave a mess in the codebase for something that realistically wouldn't give anyone any benefit?

I actually forgot about the db models, so in theory that's the situation we have now right? the models still exist but the ability to modify them would be gone? This does remind me I do also need to remove the delete-all-reminders command too though so I'll do that now.

@CarrotManMatt

CarrotManMatt commented Aug 23, 2026

Copy link
Copy Markdown
Member

Ah I think the best bet is to just mark the DB class with @warnings.deprecated.

https://typing.python.org/en/latest/spec/directives.html#deprecated

@MattyTheHacker

Copy link
Copy Markdown
Member Author

Ah I think the best bet is to just mark the DB class with @warnings.deprecated.

https://typing.python.org/en/latest/spec/directives.html#deprecated

Which class? the commands cog?

@CarrotManMatt

Copy link
Copy Markdown
Member

Sorry, db.core.models.DiscordReminder DB class. It can also be removed from __all__ in that file

@CarrotManMatt CarrotManMatt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest a note is added to the corresponding element (delete_all_reminders) in TeXBotBaseCog.ERROR_ACTIVITIES to mention that the command has been removed. But still leave the message existing in the dictionary just in case that key appears during an exception handling for some wild reason.

"delete_all_reminders": (
"delete all `DiscordReminder` objects from the backend database"
),

@MattyTheHacker

Copy link
Copy Markdown
Member Author

I suggest a note is added to the corresponding element (delete_all_reminders) in TeXBotBaseCog.ERROR_ACTIVITIES to mention that the command has been removed. But still leave the message existing in the dictionary just in case that key appears during an exception handling for some wild reason.

"delete_all_reminders": (
"delete all `DiscordReminder` objects from the backend database"
),

done

@MattyTheHacker
MattyTheHacker enabled auto-merge (squash) August 23, 2026 14:35
@CarrotManMatt CarrotManMatt added the awaiting committee review PRs awaiting approval from a CSS committee member label Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting committee review PRs awaiting approval from a CSS committee member sync Request bots to automatically keep this PR up to date with it's base branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants