feat: replay boot-time log backlog to new log stream clients - #220
Merged
Conversation
Contributor
|
cargo audit found vulnerabilities:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like docker logs, a new log stream client should see everything since container start, not just what's produced after it connects. Previously stream_logs only forwarded live reads to whatever client was currently attached and dropped everything else — boot-time output (docker-entrypoint.sh, nginx notice lines) was gone forever if no client had connected yet, since firecracker microVMs boot in well under a second and the browser tab always attaches after that.
Adds a bounded 64KB ring buffer (VecDeque) that every stdout/stderr chunk is appended to regardless of whether a client is attached. On accept, the full backlog is replayed to the new client before it starts receiving live chunks.