fix: log vsock accept guard blocks reconnects after first client - #219
Merged
Conversation
Contributor
|
cargo audit found vulnerabilities:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause of logs staying empty in the frontend even after #213/#214 landed.
stream_logs in csfx-guest-init only calls listener.accept() while client.is_none(). Once one client connects, that branch of the select! never fires again until a write to the stale client fails — which only happens on the next log line produced. If the agent side reconnects (browser tab reload, gateway retry, etc.) before another log line is written, guest-init never pulls the new connection off the accept queue: the vsock handshake succeeds at the kernel level (agent logs guest log vsock connected), but nobody on the guest side ever reads or writes on it, so the stream sits open with zero bytes forever — exactly the symptom (log client accepted logged once, but the agent shows 5 separate connect attempts, only 1 of which was actually accepted).
Fix: drop the is_none() guard so a new connection always replaces whatever was there, dead or not.