Jv/quick/bb2bucket - #577
Open
jasonvinson wants to merge 5 commits into
Open
Conversation
mianava
reviewed
Aug 18, 2026
mianava
reviewed
Aug 18, 2026
mianava
reviewed
Aug 18, 2026
mianava
reviewed
Aug 21, 2026
| Resource = "*" | ||
| Condition = { | ||
| StringEquals = { | ||
| "kms:ViaService" = "secretsmanager.${module.standards.primary_region.name}.amazonaws.com" |
Contributor
There was a problem hiding this comment.
Is something new using secretsmanager?
mianava
reviewed
Aug 21, 2026
| } | ||
|
|
||
| locals { | ||
| quicksight_role_arn = "arn:aws:iam::${data.aws_ssm_parameter.dasg_insights_account_id.value}:role/service-role/aws-quicksight-service-role-v0" |
Contributor
There was a problem hiding this comment.
Is this a required naming convention for quick?
|
|
||
| terraform { | ||
| backend "s3" { | ||
| key = "insights/export-buckets/bb2/terraform.tfstate" |
Contributor
There was a problem hiding this comment.
Is there a reason these resources are nested?
| @@ -0,0 +1 @@ | |||
| TARGET_ENVS="cdap-prod" | |||
Contributor
There was a problem hiding this comment.
I'm not sure these will be traversed if they're nested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/...
🛠 Changes
ℹ️ Context
There is an initiative to centralize all AWS Quick dashboards in the DASG Insights account. This bucket will allow a lambda in BB's account to export the CSVs used in their Quick dashboards to our prod account, which can be read by Quick in the DASG Insights account.
🧪 Validation
Will test alongside a member of BB after deployment. Plan will fail until new SOPs params are applied.