Add generalized Pareto fit to frequency curve tails#1288
Open
ValentinGebhart wants to merge 14 commits intodevelopfrom
Open
Add generalized Pareto fit to frequency curve tails#1288ValentinGebhart wants to merge 14 commits intodevelopfrom
ValentinGebhart wants to merge 14 commits intodevelopfrom
Conversation
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
util.interpolate.fit_tail_GPDto fit a generalized Pareto distribution to frequency curve data.ImpactFreqCurve.interpolate()using the optional parametermethod="fit_GPD"Comments:
scipy.stats.genpareto.fit()because I had to cumstomize the loss function to make the fit look reasonable given the data. I think this is because in CLIMADA we often have very imbalanced tail distributions with few data points for large return periods and many for smaller ones (e.g. in the first example the data return periods are [450, 225, 150, 112, 90, ...]), so it is necessary to use a cumstom loss function to put more weight of hight return periods.This PR fixes #1258
PR Author Checklist
develop)PR Reviewer Checklist