Skip to content

Fix blocked Coveralls upload by splitting main coverage workflow#378

Merged
harryswift01 merged 1 commit into
mainfrom
355-general-reintroduce-coveralls-step
Jun 26, 2026
Merged

Fix blocked Coveralls upload by splitting main coverage workflow#378
harryswift01 merged 1 commit into
mainfrom
355-general-reintroduce-coveralls-step

Conversation

@harryswift01

Copy link
Copy Markdown
Member

Summary

This PR separates pull request validation from the Coveralls baseline upload workflow. The previous workflow attempted to support both PR checks and push to main coverage uploads in the same file, but the Coveralls upload was still blocked because it depended on PR-only jobs.

Changes

Split PR CI and Coveralls workflows:

  • Replaced the combined PR/push workflow with two separate workflows:
    • Pull request CI for tests, docs, pre-commit, regression checks, and PR coverage reporting.
    • Coveralls Main for rebuilding the main branch coverage baseline on push to main.
  • Removed the push trigger from the PR CI workflow.
  • Added a dedicated coveralls-main.yaml workflow that runs independently on pushes to main.
  • Added manual workflow_dispatch support so the Coveralls baseline can be rebuilt manually when required.

Restore Coveralls coverage reporting:

  • Keeps PR coverage uploads to Coveralls so coverage changes can be checked during review.
  • Adds a dedicated main branch Coveralls upload to maintain the baseline used for PR coverage comparisons.
  • Keeps coverage generation through pytest-cov and coverage.xml.

Impact

  • Restores Coveralls uploads on push to main.
  • Ensures the main branch coverage baseline is rebuilt after merges.
  • Allows PRs to be checked against the latest main coverage baseline.
  • Avoids skipped-job dependency issues caused by mixing PR-only and push-to-main logic in one workflow.

@harryswift01 harryswift01 added this to the 2.3.0 milestone Jun 26, 2026
@harryswift01 harryswift01 requested a review from jimboid June 26, 2026 08:22
@harryswift01 harryswift01 self-assigned this Jun 26, 2026
@harryswift01 harryswift01 added the bug Something isn't working label Jun 26, 2026

@jimboid jimboid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR will fix the issue described.

@harryswift01 harryswift01 merged commit e6ee141 into main Jun 26, 2026
43 of 45 checks passed
@harryswift01 harryswift01 deleted the 355-general-reintroduce-coveralls-step branch June 26, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[General]: Reintroduce coveralls step back into PR merge to create base branches again

2 participants