fix(rust): harden network block framing#2294
Open
GautamSharma99 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens the Rust networking implementation against fragmented TCP I/O and oversized protocol blocks.
The existing implementation assumed that a single
TcpStream::read()orTcpStream::write()transferred the entire requestedbuffer. TCP does not guarantee this: successful operations may process only part of the supplied buffer.
A partial operation could leave the custom network protocol out of sync because the next call would interpret the remainder of the
previous block as a new command.
This PR also prevents peer-provided block lengths from causing an unbounded allocation or an out-of-bounds copy into the buffer
supplied through the C/Rust FFI boundary.
Problem
CCExtractor's network protocol encodes blocks as: