CRDCDH-3807 Support SRF In Revision workflow - #89
Open
amattu2 wants to merge 1 commit into
Open
Conversation
#281 Bundle Size — 12.87MiB (~+0.01%).a602ba9(current) vs 060bcd4 3.7.0#275(baseline) Warning Bundle contains 54 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch CRDCDH-3807 Project dashboard Generated by RelativeCI Documentation Report issue |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the frontend SRF workflow to support the new “In Revision” status, aligning status typing, permissions, filters, and UI messaging/tooltip text with the updated lifecycle.
Changes:
- Adds
"In Revision"toApplicationStatustyping and to status-driven UI behavior (editability, tooltips, list filtering defaults). - Centralizes and tests save-status selection via a new
computeNextStatushelper (New / In Progress / In Revision). - Updates permissions and resume/edit paths to consistently treat
"In Revision"as an editable/submittable draft state.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/frontend/src/utils/formUtils.ts | Adds computeNextStatus helper to determine save-time SRF status. |
| apps/frontend/src/utils/formUtils.test.ts | Adds unit tests covering the new status decision rules. |
| apps/frontend/src/utils/formModeUtils.ts | Includes "In Revision" in EditStatuses to keep form editable in that state. |
| apps/frontend/src/utils/formModeUtils.test.ts | Updates form-mode tests to include "In Revision" in editable status sets. |
| apps/frontend/src/types/Application.d.ts | Adds "In Revision" to the ApplicationStatus union type. |
| apps/frontend/src/graphql/saveApplication.ts | Expands allowed status input typing to include "In Revision". |
| apps/frontend/src/content/questionnaire/ListView.tsx | Reuses shared EditStatuses for the Resume action instead of an inline list. |
| apps/frontend/src/content/questionnaire/ListView.test.tsx | Updates default-status expectations to include "In Revision". |
| apps/frontend/src/content/questionnaire/ListFilters.tsx | Adds "In Revision" into default selected statuses and selectable status options. |
| apps/frontend/src/content/questionnaire/FormView.tsx | Updates reopen-flow error messaging to reference “In Revision”. |
| apps/frontend/src/config/QuestionnaireTooltips.ts | Adds tooltip text for the new "In Revision" status. |
| apps/frontend/src/config/AuthPermissions.ts | Allows submit/cancel flows to include "In Revision" where appropriate. |
| apps/frontend/src/config/AuthPermissions.test.ts | Updates permission tests to include "In Revision" as a valid submit status. |
| apps/frontend/src/components/StatusBar/StatusBar.test.tsx | Adds tooltip expectation for "In Revision" in status history modal tests. |
| apps/frontend/src/components/Contexts/FormContext.tsx | Switches save-status logic to computeNextStatus and preserves "In Revision" on saves. |
| apps/frontend/src/components/Contexts/FormContext.test.tsx | Updates reopen/resume test to expect "In Revision" status. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the complimenting "In Revision" SRF workflow changes to the frontend.
Change Details (Specifics)
Related Ticket(s)
CRDCDH-3744 (US)
CRDCDH-3807 (Task)