Skip to content

CRDCDH-3807 Support SRF In Revision workflow - #89

Open
amattu2 wants to merge 1 commit into
CRDCDH-3744from
CRDCDH-3807
Open

CRDCDH-3807 Support SRF In Revision workflow#89
amattu2 wants to merge 1 commit into
CRDCDH-3744from
CRDCDH-3807

Conversation

@amattu2

@amattu2 amattu2 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Overview

This PR adds the complimenting "In Revision" SRF workflow changes to the frontend.

Change Details (Specifics)

  • Implement "In Revision" status to typing
  • Update default status filters for all roles to include this status
  • Migrate the logic to determine what status a SRF should be saved as (New, In Progress, In Revision)
  • Deduplicate config definitions of what constitutes an active SRF (Used by list page and form mode)
  • Add history dialog tooltip for the new status

Related Ticket(s)

CRDCDH-3744 (US)
CRDCDH-3807 (Task)

@relativeci

relativeci Bot commented Jul 27, 2026

Copy link
Copy Markdown

#281 Bundle Size — 12.87MiB (~+0.01%).

a602ba9(current) vs 060bcd4 3.7.0#275(baseline)

Warning

Bundle contains 54 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#281
     Baseline
#275
Regression  Initial JS 878.38KiB(+0.02%) 878.22KiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 27.93% 28.67%
No change  Chunks 74 74
No change  Assets 117 117
No change  Modules 9161 9161
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 320 320
No change  Duplicate Packages 53 53
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#281
     Baseline
#275
Regression  JS 10.35MiB (~+0.01%) 10.35MiB
No change  IMG 1.72MiB 1.72MiB
No change  Fonts 805.07KiB 805.07KiB
No change  CSS 18KiB 18KiB

Bundle analysis reportBranch CRDCDH-3807Project dashboard


Generated by RelativeCIDocumentationReport issue

@amattu2
amattu2 changed the base branch from 3.7.0 to CRDCDH-3744 July 27, 2026 14:42
@amattu2
amattu2 requested a review from Copilot July 27, 2026 18:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the frontend SRF workflow to support the new “In Revision” status, aligning status typing, permissions, filters, and UI messaging/tooltip text with the updated lifecycle.

Changes:

  • Adds "In Revision" to ApplicationStatus typing and to status-driven UI behavior (editability, tooltips, list filtering defaults).
  • Centralizes and tests save-status selection via a new computeNextStatus helper (New / In Progress / In Revision).
  • Updates permissions and resume/edit paths to consistently treat "In Revision" as an editable/submittable draft state.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
apps/frontend/src/utils/formUtils.ts Adds computeNextStatus helper to determine save-time SRF status.
apps/frontend/src/utils/formUtils.test.ts Adds unit tests covering the new status decision rules.
apps/frontend/src/utils/formModeUtils.ts Includes "In Revision" in EditStatuses to keep form editable in that state.
apps/frontend/src/utils/formModeUtils.test.ts Updates form-mode tests to include "In Revision" in editable status sets.
apps/frontend/src/types/Application.d.ts Adds "In Revision" to the ApplicationStatus union type.
apps/frontend/src/graphql/saveApplication.ts Expands allowed status input typing to include "In Revision".
apps/frontend/src/content/questionnaire/ListView.tsx Reuses shared EditStatuses for the Resume action instead of an inline list.
apps/frontend/src/content/questionnaire/ListView.test.tsx Updates default-status expectations to include "In Revision".
apps/frontend/src/content/questionnaire/ListFilters.tsx Adds "In Revision" into default selected statuses and selectable status options.
apps/frontend/src/content/questionnaire/FormView.tsx Updates reopen-flow error messaging to reference “In Revision”.
apps/frontend/src/config/QuestionnaireTooltips.ts Adds tooltip text for the new "In Revision" status.
apps/frontend/src/config/AuthPermissions.ts Allows submit/cancel flows to include "In Revision" where appropriate.
apps/frontend/src/config/AuthPermissions.test.ts Updates permission tests to include "In Revision" as a valid submit status.
apps/frontend/src/components/StatusBar/StatusBar.test.tsx Adds tooltip expectation for "In Revision" in status history modal tests.
apps/frontend/src/components/Contexts/FormContext.tsx Switches save-status logic to computeNextStatus and preserves "In Revision" on saves.
apps/frontend/src/components/Contexts/FormContext.test.tsx Updates reopen/resume test to expect "In Revision" status.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@amattu2
amattu2 marked this pull request as ready for review July 27, 2026 19:39
@amattu2
amattu2 requested a review from Alejandro-Vega July 27, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants