Skip to content

CRDCDH-3811 Introduce In Revision status flow - #88

Merged
n2iw merged 2 commits into
CRDCDH-3744from
CRDCDH-3811
Jul 28, 2026
Merged

CRDCDH-3811 Introduce In Revision status flow#88
n2iw merged 2 commits into
CRDCDH-3744from
CRDCDH-3811

Conversation

@amattu2

@amattu2 amattu2 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Overview

This PR implements the backend portion of the new "In Revision" SRF workflow change, where an "Inquired" SRF now becomes "In Revision" when opened by the submitter.

Change Details (Specifics)

N/A

Related Ticket(s)

CRDCDH-3744 (US)
CRDCDH-3811 (Task)

@relativeci

relativeci Bot commented Jul 27, 2026

Copy link
Copy Markdown

#284 Bundle Size — 12.87MiB (+100%).

⚠️ Baseline job is missing

Warning

Bundle contains 54 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#284
     Baseline
No change  Initial JS 878.22KiB -
No change  Initial CSS 0B -
No change  Cache Invalidation 0% -
No change  Chunks 74 -
No change  Assets 117 -
No change  Modules 9161 -
No change  Duplicate Modules 0 -
No change  Duplicate Code 0% -
No change  Packages 320 -
No change  Duplicate Packages 53 -
Bundle size by type  no changes
                 Current
#284
     Baseline
No change  JS 10.35MiB (+100%) -
No change  IMG 1.72MiB (+100%) -
No change  Fonts 805.07KiB (+100%) -
No change  CSS 18KiB (+100%) -

Bundle analysis reportBranch CRDCDH-3811Project dashboard


Generated by RelativeCIDocumentationReport issue

@amattu2
amattu2 changed the base branch from 3.7.0 to CRDCDH-3744 July 27, 2026 14:42
@amattu2
amattu2 requested a review from Copilot July 27, 2026 18:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new SRF status, In Revision, to support the updated workflow where an Inquired SRF transitions to In Revision when the submitter resumes work. The change updates backend constants, service-layer status handling, GraphQL schema documentation, DAO inactivity selection, and the relevant unit test.

Changes:

  • Added IN_REVISION application status constant.
  • Updated Application service status lists/order, version auto-upgrade logic, and resumeInquiredApplication transition target to IN_REVISION.
  • Updated GraphQL schema documentation and DAO inactive-status filtering; updated the resume test expectation.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
apps/backend/constants/application-constants.js Adds the IN_REVISION status constant.
apps/backend/services/application.js Threads IN_REVISION through status handling, version selection, and resume transition logic.
apps/backend/dao/application.js Includes IN_REVISION in inactivity queries.
apps/backend/resources/graphql/crdc-datahub.graphql Updates schema comments/docs to include “In Revision” and the new transition wording.
apps/backend/test/services/application.test.js Updates the resume test to expect IN_REVISION.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/backend/services/application.js Outdated
Comment thread apps/backend/services/application.js
Comment thread apps/backend/test/services/application.test.js
@amattu2
amattu2 marked this pull request as ready for review July 27, 2026 19:38
@amattu2
amattu2 requested a review from n2iw July 27, 2026 19:38

@n2iw n2iw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n2iw
n2iw merged commit 15ef420 into CRDCDH-3744 Jul 28, 2026
15 checks passed
@n2iw
n2iw deleted the CRDCDH-3811 branch July 28, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants