fix: exit host runtime when official app-server closes - #91
Open
mouzhi wants to merge 2 commits into
Open
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Collaborator
Author
|
CI note: the failing
The four changed files pass a focused Prettier check. Locally, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Incident evidence
On macOS, the CodexHost launcher, shim, and Host Runtime remained alive after the owned official Codex app-server child had disappeared. The Desktop connection therefore looked connected while all six request slots were occupied;
model/list,config/read, permissions, plugins, and MCP requests expired in the queue. A controlled restart restored the official child and immediately restored a 43-modelmodel/listresponse.Validation
timed-out, then passed after the lifecycle changepackages/host-runtime/test/app-server-host.test.ts: 115 passednpm run lint: passednpm run typecheck: passednpm run test:typescript: 173 files passed, 1 skipped; 1495 tests passed, 15 skippednpm run check:rust: passedcargo fmt --all --check: passednpm run format:checkis currently blocked by two pre-existingorigin/mainformatting failures outside this diff:packages/host-runtime/test/remote-host-lifecycle.test.tspackages/renderer-extension/src/settings/windows-update.preview.html