feat: 适配 DeepSeek Harness goal 与 plan 文本命令 - #71
Conversation
|
暂不合并 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6945533577
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ( | ||
| !this.#active && | ||
| this.#bufferAutonomousEvent(frame.event.type, frame.event.data, frame.event.seq) | ||
| ) { |
There was a problem hiding this comment.
When /goal or /plan starts a native Turn before commands/execute settles, this branch buffers only session/event frames while #active remains null. Any approval/requested or question/requested arriving during that interval bypasses the buffer and is immediately rejected or cancelled by #approval/#question because there is no active Host Turn. Consequently, command-triggered model work that needs a tool approval or user answer cannot complete correctly; preserve these interaction frames with the pending autonomous Turn and replay them after it is activated.
Useful? React with 👍 / 👎.
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@omsd512-W 合并吗 ，或者优化完毕后@ 我一下 |
5267bb5 to
f7bed4d
Compare
f7bed4d to
05e6e9f
Compare
omsd512-W
changed the title
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05e6e9f743
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| this.#pendingExternalCommandRequests.add(thread.id); | ||
| try { | ||
| const catalog = await thread.session.commands.list(); |
There was a problem hiding this comment.
When an autonomous Harness Turn arrives while this catalog request is awaiting, its handler sets thread.running and activeTurnId, but a normal non-slash submission falls through after the finally without rechecking either value. It then overwrites that state with a new projection; if the Adapter rejects the second start as busy, its cleanup sets the Thread back to idle while the autonomous Turn is still running. Reject or restart the request after discovery when the Thread became active.
Useful? React with 👍 / 👎.
2 participants
目标
为 DeepSeek Harness 接入 codexhost 现有 Harness Command 流程，支持通过 Composer 的 Harness 命令入口调用 DSH 原生
/goal与/plan，同时保留动态发现的/compact。codexhost 只负责能力发现、路由和结果投影，DSH 继续拥有 goal、plan 与会话状态。实现
commands/list动态生成命令目录，并在执行前重新确认能力。compact、goal、plan；目录缺失、不兼容或畸形时失败关闭。/dsh-goal [<objective>|clear|edit <objective>|pause|resume]，在 DeepSeek Adapter 内映射为原生/goal，避免进入 Codex Desktop 内置/goal流程。/plan [off|message]，直接映射为 DSH 原生/plan。commands/execute，并复用现有 Command Execution Item、Turn 生命周期、取消和错误投影。边界
/dsh-goal与/plan仅支持文本输入。External Harness 文本 Turn 携带image或localImage时，Host 会在 Adapter 执行前明确拒绝，不会静默丢图。/feedback，因为它与 Codex Desktop 内置/feedback冲突。/permission、/model、/export或未知命令；权限与模型继续使用 codexhost 现有一级控件。提交
d7a3dc7 feat: 扩展 DeepSeek Harness 文本命令适配6900461 feat: 路由 Harness 文本命令提交4f7062b feat: 添加 Harness 文本命令编辑器入口9f79f7d docs: 更新 DeepSeek Harness 命令规范05e6e9f chore: 修复上游格式检查05e6e9f仅格式化上游带入的remote-host-lifecycle.test.ts，并将生成型windows-update.preview.html加入.prettierignore，没有修改相关运行逻辑。验证
npm cinpm run check：Prettier、ESLint、boundary、TypeScript typecheck、TypeScript tests、Clippy 与全部 Rust tests 本地通过npx openspec validate --all --strict --no-interactive：53/53 通过git diff --checkreplacement_does_not_signal_a_reused_owner_process_id偶发收到Access is denied (os error 5)；本 PR 未修改该测试及其实现，本机连续重跑 10 次全部通过，等待仓库 Owner 重跑失败 Job当前保持 Draft，不请求合并。