Window adjustments and fixes for all backends#234
Conversation
* make platformGetWindowScale just return a float there shouldn't be any platforms where scalex != scaley * use the thing * fix * fix sdl3 scaling * fi * is this not scaled??? * just inline
| switch (e.type) { | ||
| default: | ||
| if (InputRecording_isPlaybackActive(globalInputRecording)) continue; | ||
| break; |
There was a problem hiding this comment.
remove this break; it does nothing
|
This is a very big diff, and it has parts that I know aren't ready. Could you make a 2nd PR with just the following bits that are pretty simple and look ready SDL1 ALT+F4 fix |
|
There were window related fixes as the title said, though it makes sense to add some of them separately, the small fixes would be a separate PR, though for the window things it would make more sense to actually implement the window VM builtins (fullscreen, window pos, center, etc). Would keep it as a draft and take it's changes separately so it can be properly reviewed, the idea would be like this for each PR:
The large resoultion fix could be in the window vm pr or after it was reviewed or merged (alongside support for old sdl1.2/sdl2.0). |
Main changes for all backends
Specific backend changes
GLFW2
SDL1
SDL3
Description