Upgrade/laravel 13 - #1
Open
bullet-john wants to merge 6 commits into
Open
Conversation
Doctrine ORM 3 removes the annotation mapping driver, so the entity traits need PHP attributes. The annotations are kept alongside them, following the same dual mapping approach as laravel-doctrine/extensions 1.x, so consumers still running the annotation driver are unaffected. The two forms must be kept in sync until the annotation form is dropped. Activatable, Identifiable and TwoFactorAuthenticatable carried no ORM import, because annotations resolved through the consuming entity's imports. Attributes resolve against the trait's own file, so those imports are added. Widens the framework constraints rather than replacing them, so consumers on Laravel 11 and ORM 2 keep working with this release.
The package never used ACL's classes. Requiring it forced doctrine/annotations into every consuming app, which in turn made Gedmo select the annotation reader over the attribute reader under Doctrine ORM 3.
Use the explicit ?Carbon nullable type for setTwoFactorConfirmedAt().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.