Skip to content

GAUD-10062: fix webkit tests#995

Merged
dlockhart merged 1 commit into
mainfrom
GAUD-10062/fix-broken-local-webkit-tests
May 22, 2026
Merged

GAUD-10062: fix webkit tests#995
dlockhart merged 1 commit into
mainfrom
GAUD-10062/fix-broken-local-webkit-tests

Conversation

@dlockhart
Copy link
Copy Markdown
Member

These tests only fail on my dev machine, not in CI. The calls to getBoundingClientRect return decimal values whereas the mouse positions are integers.

@dlockhart dlockhart requested a review from a team as a code owner May 22, 2026 14:59
Copy link
Copy Markdown
Contributor

@bearfriend bearfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised floor works instead of ceil/round 🤷

@dlockhart
Copy link
Copy Markdown
Member Author

I'm surprised floor works instead of ceil

Yeah they were all .34375.

@dlockhart dlockhart merged commit ec21c32 into main May 22, 2026
4 checks passed
@dlockhart dlockhart deleted the GAUD-10062/fix-broken-local-webkit-tests branch May 22, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants