fix(webui): ClassCastException displaying range component values - #12
Open
tipatterson-dev wants to merge 4 commits into
Open
fix(webui): ClassCastException displaying range component values#12tipatterson-dev wants to merge 4 commits into
tipatterson-dev wants to merge 4 commits into
Conversation
Range components (QuantityRange etc.) are SimpleComponents but not DataValues, so rendering their latest value in the admin UI crashed. getStringValue(SimpleComponent) handles scalars and ranges alike.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The admin UI's SWE component form casts every simple component to
DataValuewhen rendering its latest value. Range components (QuantityRange,CountRange,TimeRange) areSimpleComponents but notDataValues, so expanding an output containing a range with values shown crashed the panel with aClassCastException.Fix: cast to
SimpleComponentinstead —SWEDataTypeUtils.getStringValue(SimpleComponent)already renders both scalars and ranges, so scalar behavior is unchanged.Repro: browse any driver output containing a
QuantityRangein the Admin UI with data present (e.g. a sensor reporting a min/max pair) and expand its structure.