Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an initial “Firewall” app surface to NETworkManager, including a WPF DataGrid-based UI and a new firewall model layer that loads NETworkManager-owned Windows Firewall rules via PowerShell.
Changes:
- Introduce a new Firewall rules grid UI with row details, search, refresh, and context menus.
- Add a new
NETworkManager.Models.Firewallmodel layer (rule DTOs + PowerShell-backed rule loading/parsing). - Add supporting enums/models (protocols, directions, port specs, interface types, network profiles).
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Source/NETworkManager/Views/FirewallView.xaml.cs | Adds click handler to toggle DataGrid row details. |
| Source/NETworkManager/Views/FirewallView.xaml | Reworks Firewall view to a searchable/refreshable MultiSelectDataGrid with row details. |
| Source/NETworkManager/ViewModels/FirewallViewModel.cs | Adds rule collection/view, filtering, refresh logic, and rule-related commands (mostly TODO). |
| Source/NETworkManager.Models/NETworkManager.Models.csproj | Adds Firewall folder entry to the Models project. |
| Source/NETworkManager.Models/Network/NetworkProfiles.cs | Adds enum representing Windows network profiles. |
| Source/NETworkManager.Models/Firewall/FirewallRuleProgram.cs | Adds program/path model for firewall rules. |
| Source/NETworkManager.Models/Firewall/FirewallRuleDirection.cs | Adds inbound/outbound direction enum. |
| Source/NETworkManager.Models/Firewall/FirewallRuleAction.cs | Adds allow/block action enum. |
| Source/NETworkManager.Models/Firewall/FirewallRule.cs | Adds firewall rule DTO + display helpers. |
| Source/NETworkManager.Models/Firewall/FirewallProtocol.cs | Adds protocol enum mapping (incl. Any/255). |
| Source/NETworkManager.Models/Firewall/FirewallPortSpecification.cs | Adds port range/single-port specification model. |
| Source/NETworkManager.Models/Firewall/FirewallPortLocation.cs | Adds local vs remote port location enum. |
| Source/NETworkManager.Models/Firewall/FirewallInterfaceType.cs | Adds interface type enum. |
| Source/NETworkManager.Models/Firewall/Firewall.cs | Adds PowerShell-based rule discovery + parsing helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/BornToBeRoot/NETworkManager/sessions/5215e397-497d-4847-a3f7-a7454cafebb3 Co-authored-by: BornToBeRoot <16019165+BornToBeRoot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 48 out of 52 changed files in this pull request and generated 11 comments.
Files not reviewed (2)
- Source/NETworkManager.Localization/Resources/StaticStrings.Designer.cs: Language not supported
- Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
@copilot resolve the merge conflicts in this pull request |
Resolve conflicts: - Website/package.json: take react/react-dom ^19.2.5 from main (Dependabot bump) - Website/yarn.lock: update package keys to match ^19.2.5 Co-authored-by: BornToBeRoot <16019165+BornToBeRoot@users.noreply.github.com>
Contributor
Merge conflicts resolved in 3f9768f. The only conflicts were in |
…BeRoot/NETworkManager into feature/firewall-app-base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Related issue(s)
To-Do