Skip to content

ENH: Changed test macros to copy result #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JDuffeyBQ wants to merge 1 commit into
base: develop
Choose a base branch
from
+21 −4
Draft

ENH: Changed test macros to copy result #1709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions test/UnitTestCommon/include/simplnx/UnitTest/UnitTestCommon.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,15 @@
namespace fs = std::filesystem;
using namespace nx::core;

namespace nx::core
{
// Concept that checks if T is an instance of Result<T>
template <class T>
concept IsResult = requires(T x) {

Check failure on line 47 in test/UnitTestCommon/include/simplnx/UnitTest/UnitTestCommon.hpp

View workflow job for this annotation

GitHub Actions / clang_format_pr 

code should be clang-formatted [-Wclang-format-violations]
{ Result{x} } -> std::same_as<T>;

Check failure on line 48 in test/UnitTestCommon/include/simplnx/UnitTest/UnitTestCommon.hpp

View workflow job for this annotation

GitHub Actions / clang_format_pr 

code should be clang-formatted [-Wclang-format-violations]

Check failure on line 48 in test/UnitTestCommon/include/simplnx/UnitTest/UnitTestCommon.hpp

View workflow job for this annotation

GitHub Actions / clang_format_pr 

code should be clang-formatted [-Wclang-format-violations]

Check failure on line 48 in test/UnitTestCommon/include/simplnx/UnitTest/UnitTestCommon.hpp

View workflow job for this annotation

GitHub Actions / clang_format_pr 

code should be clang-formatted [-Wclang-format-violations]
};
Comment on lines +48 to +49

@github-actions github-actions Bot Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clang-format] reported by reviewdog 🐶

Suggested change
{ Result{x} } -> std::same_as<T>;
};
{
Result{x}
} -> std::same_as<T>;
};

} // namespace nx::core

#define SIMPLNX_RESULT_CATCH_PRINT(result) \
for(const auto& warning : (result).warnings()) \
{ \
Expand All @@ -54,12 +63,20 @@
}

#define SIMPLNX_RESULT_REQUIRE_VALID(result) \
SIMPLNX_RESULT_CATCH_PRINT(result); \
REQUIRE((result).valid());
do \
{ \
const IsResult auto NX_TEST_RESULT = (result); \
SIMPLNX_RESULT_CATCH_PRINT(NX_TEST_RESULT); \
REQUIRE(NX_TEST_RESULT.valid()); \
} while(false);

#define SIMPLNX_RESULT_REQUIRE_INVALID(result) \
SIMPLNX_RESULT_CATCH_PRINT(result); \
REQUIRE((result).invalid());
do \
{ \
const IsResult auto NX_TEST_RESULT = (result); \
SIMPLNX_RESULT_CATCH_PRINT(NX_TEST_RESULT); \
REQUIRE(NX_TEST_RESULT.invalid()); \
} while(false);

namespace nx::core
{
Expand Down
Loading