BUG: MultiThresholdObjects unit testing#1599
Open
mmarineBlueQuartz wants to merge 12 commits intoBlueQuartzSoftware:developfrom
Open
BUG: MultiThresholdObjects unit testing#1599mmarineBlueQuartz wants to merge 12 commits intoBlueQuartzSoftware:developfrom
mmarineBlueQuartz wants to merge 12 commits intoBlueQuartzSoftware:developfrom
Conversation
* Updated MultiThresholdObjects algorithm to account for the IsInverted state allowed by individual thresholds. * WIP: Replacing unit tests with smaller datasets and standardized testing functions. Integer and floating point single component DataArrays are tested for all comparison types and inversion states using a single threshold. Multicomponent arrays are in the process of being tested and the filter was updated for assumptions that may be wrong. The documentation and GUI need to be referenced before moving forward. Multicomponent threshold tests and threshold creation will likely need to be adjusted based on new information. * TODO: Create tests for entire threshold sets and even nested sets.
* Mask array is always 1 component. * Update unit tests for multicomponent array thresholds
* Consolidated unit tests of the same array type and component count using GENERATE. * Added additional value checks. * All single threshold tests pass.
* Removed requirement for input arrays to all have the same number of components, Each threshold specifies the target component.
* MultiThresholdObjects no longer writes directly to the DataStore when running Thresholds. Instead Sets and Thresholds both store temporary vectors that are copied to the parent set's vector. The topmost ThresholdSet copies the vector to the DataStore upon completion. * Added ThresholdSet unit tests.
* Standardized apply threshold values between thresholds and sets. * Removed unnecessary inversion parameter in threshold and set algorithm
* Re-enabled unit test without the Mismatched components section. That case is no longer an error.
* Added function documentation for ApplyThresholdValues * Simplified InsertThreshold parameters. * Deleted unused ThresholdValueFunctor struct.
* Re-enabled invalid execution and mask DataType unit tests and updated for new tuple counts. * Simplified mask DataType unit tests to remove duplicated code. * Removed unused legacy unit tests.
mmarineBlueQuartz
force-pushed
the
mtr/MultiThresholdObjects
branch
from
19abfa0 to
7038909
Compare
mmarineBlueQuartz
changed the title
* Converted std::vector data to AbstractDataStore<T> using DataStoreUtilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.