Adapt resolution.rs to resolve use statements and add module errors#339
Merged
KyrylR merged 2 commits intoJun 2, 2026
Merged
Conversation
KyrylR
reviewed
Jun 1, 2026
| file_candidate.set_extension("simf"); | ||
|
|
||
| if !file_candidate.is_file() { | ||
| return Err(file_candidate); |
Collaborator
There was a problem hiding this comment.
nit: add as many context as possible
Collaborator
Author
There was a problem hiding this comment.
Add docstring and comments for this
LesterEvSe
force-pushed
the
feature/adapt-resolution
branch
from
b4e05c2 to
5fb820f
Compare
Collaborator
|
Needs rebase |
LesterEvSe
force-pushed
the
feature/adapt-resolution
branch
from
5fb820f to
aa5153f
Compare
KyrylR
approved these changes
Jun 2, 2026
KyrylR
merged commit aa5153f
into
BlockstreamResearch:dev/modules
10 of 11 checks passed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolution.rsto correctly resolveusestatement paths.