Add module parser#338
Merged
KyrylR merged 1 commit intoJun 2, 2026
Merged
Conversation
KyrylR
reviewed
Jun 1, 2026
| Use, | ||
| Module, | ||
| /// A placeholder used for error recovery during parsing. | ||
| Ignored, |
Collaborator
There was a problem hiding this comment.
Let's have a dedicated issue for the need of this keyword
Collaborator
Author
There was a problem hiding this comment.
Add documentation for that
KyrylR
reviewed
Jun 1, 2026
| } | ||
| } | ||
|
|
||
| // TODO: Fix the formatter |
Collaborator
There was a problem hiding this comment.
nit: for the future let's have more reasoning in text for the todos
KyrylR
reviewed
Jun 1, 2026
| #[cfg(feature = "arbitrary")] | ||
| impl<'a> arbitrary::Arbitrary<'a> for ModuleName { | ||
| fn arbitrary(u: &mut arbitrary::Unstructured<'a>) -> arbitrary::Result<Self> { | ||
| // TODO: Consider to change it |
Collaborator
There was a problem hiding this comment.
nit: we should move it out of the local scope
reserved names sound like something that other functions can benefit from
Collaborator
Author
There was a problem hiding this comment.
Moved the constants into the crate's scope and added public functions for the corresponding checks
LesterEvSe
force-pushed
the
feature/module-parsing
branch
from
d37a9dd to
c835f1a
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a working
Modulestruct and handle recursive parsing. In this series of PRs, we do not plan to support qualified calls via::(e.g.,unit_1::call_function), as our existing alias system is sufficient.