Add error recovery for AST analysis#217
Draft
gerau wants to merge 2 commits into
Draft
Conversation
gerau
force-pushed
the
simc/analyzer-multiple-errors
branch
2 times, most recently
from
February 16, 2026 12:47
b95d57c to
fcf910f
Compare
gerau
changed the title
gerau
marked this pull request as ready for review
February 16, 2026 13:40
This adds error states for `parse::Expression`, `ast::Expression` `ResolvedType` and `AliasedType`. Error recovery introduced by `chumsky` parser require some default states to recover to, which was represented before with dummy values, like unit type for expression or alias with `error` name. However, this kind of recovery is not desirable in case of further analyzing of parse tree, because it would lead to unrecognazible errors on analyzer.
gerau
force-pushed
the
simc/analyzer-multiple-errors
branch
from
February 18, 2026 09:54
fcf910f to
2f99ae4
Compare
Add error reporting and remade `Program::analyze` function, so it would return `Option` like it is done right now with parsing. All errors should be return from `Result` or be reported to the scope.
gerau
force-pushed
the
simc/analyzer-multiple-errors
branch
from
February 18, 2026 11:42
2f99ae4 to
66b913e
Compare
Contributor
|
Please add a description and some motivation to this PR. |
Contributor
Author
|
Also, I would like to merge this after the PR with modules implementation, so maybe I would change it to draft instead |
gerau
marked this pull request as draft
March 3, 2026 18:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #207.
This implementation adds error recovery to
analyze, which previously returned only one error, similar to an oldpestparser. I have also added error states for expressions and types in theastandparsemodules.This should provide multiple errors during the analysis stage, which is a logical step forward after implementing error recovery during the parsing stage. I am not sure if this is the correct implementation, so I would be happy to hear if there is another way to do this.