Fix Monitor bug with preallocated buffers and torch.cat#761
Open
steampunc wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found an issue with the Monitor class's static buffers, which this PR fixes.
bindsnet.network.monitors.Monitorseems to support a preallocated buffer mode where you pass a simulation duration at construction, which leadsreset_state_variablesto fill a recording list with placeholders.record()appends the new tensors and pops the empty placeholders from the head of the list, keeping total length at some timeT. This works when the run length equalsT, but if it runs for fewer thanTsteps, the list ends up with a mix of tensors and the[]placeholders.torch.cat(self.recording[var], 0)crashes when it's called on this mixed list.Reproducing
Causes:
The current workaround I've used in some downstream code is to just always construct monitors in dynamic mode (
time=None), but this gives up the speed benefit of preallocation.To fix this more properly, I've added a list comprehension in
.get()to filter for just the tensors before passing the list totorch.cat. This drops the empty placeholders, so a short run returns a tensor of shape[truncated_run_length, ...]instead of crashing. A run that's filled the buffer still returns the full[T, ...].