Repository navigation
Explain residue-level evidence in the shared inspector - #30
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The source labels do not meet minimum contrast requirements for normal text.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds residue-level evidence explanations to the shared inspector without creating a composite quality score.
Changes:
- Adds evidence composition and severity ordering.
- Renders and documents the expandable evidence panel.
- Adds unit and browser coverage.
| File | Description |
|---|---|
shinyRam/R/inspection.R |
Builds residue evidence signals. |
shinyRam/app.R |
Renders evidence in the inspector. |
shinyRam/www/styles.css |
Styles evidence cards and severity levels. |
docs/inspection-user-guide.md |
Documents evidence interpretation. |
tests/inspection.R |
Tests evidence composition. |
tests/ui-browser.cjs |
Verifies panel availability. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| .ram-evidence-item-head strong { color:#294f55; font-size:10px; } | ||
| .ram-evidence-item-head span { | ||
| color:#75898d; font-size:8px; text-transform:uppercase; letter-spacing:.04em; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an evidence explanation panel for the currently selected residue without introducing a composite quality score.
The inspector can explain, when present:
Not allowedor near-contour positions;Each signal keeps its source and explanation. Quiet residues explicitly report that no unusual signal is present in the currently available evidence. Unit tests cover warning composition and the browser workflow verifies that every selected residue exposes the explanation panel.