AP-776: Fix "pkeys are immutable on OpenSSL 3.0" error when connecting to LBNL#5
Merged
Merged
Conversation
danschmidt5189
force-pushed
the
AP-776-openssl_3.0_too_good
branch
2 times, most recently
from
8ac2792 to
7ec6da5
Compare
awilfox
approved these changes
Jul 8, 2026
awilfox
left a comment
awilfox
left a comment
Member
There was a problem hiding this comment.
r+! Glad to see that OpenSSL 3 support was merged into the upstream gems. That's a lot easier than trying to fix it ourselves. Thanks for checking.
| ensure | ||
| old_lbnl_filename.nil? ? ENV.delete('LBNL_FILENAME') : ENV['LBNL_FILENAME'] = old_lbnl_filename | ||
| end | ||
|
|
Member
There was a problem hiding this comment.
Nice, this will make future testing easier (as I always had to remember to set that environment variable locally).
| # correctly) refuse. If you want to test manually, then for now you must | ||
| # explicitly allow the old algorithm by passing the following option to your | ||
| # sftp client: `-oKexAlgorithms=+diffie-hellman-group1-sha1`. | ||
| opts[:append_all_supported_algorithms] = true |
- Bumps net-ssh/sftp to fix that error. - Resolves issue connecting to LBNL. - Removes special KEX configuration for GOBI which is no longer required.
danschmidt5189
force-pushed
the
AP-776-openssl_3.0_too_good
branch
from
7ec6da5 to
87e3999
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functional change here is just bumping net-ssh and net-sftp:
I tested both the LBNL and GOBI downloaders in the Swarm—they work. This suggests that GOBI may have updated its SFTP server, so I'm going to test out removing our added config for their outdated kex algo.