Conversation
Agent-Logs-Url: https://github.com/BentoBoxWorld/BentoBox/sessions/4074072d-5ba3-4cdc-aaae-6bc4eabd80c2 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix island creation changing home location of previous island
Add regression test confirming island home location is set on the correct island during concurrent creation
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a player spams
/is create, a race condition caused island 1's home location to be overwritten with island 2's spawn point. The bug:postCreationTaskcalledsetHomeLocation(user, spawn), which resolves the target island by UUID primary-island lookup — but by the time island 1's paste callback fires, island 2 creation has already updated the primary pointer, so the home lands on the wrong island.The fix (
setHomeLocation(island, spawn, "")) was already applied in the codebase, targeting the specific island object directly.Changes
testBuilderWithSpawnPointSetsHomeOnIslandDirectly): makes the Bukkit scheduler execute the post-creation runnable inline, stubs a non-null spawn point, then asserts:setHomeLocation(island, spawnLoc, "")is called with the exact island referencesetHomeLocation(user, ...)is never called during island creation