Fix inPurge race condition and housekeeping timestamp-on-success semantics

[Copilot]

Three correctness issues flagged in PR review: deleteEverything() left inPurge unset during async deletion (allowing concurrent purges), housekeeping cycles advanced their last-run timestamp unconditionally even on error, and the class Javadoc described a non-existent single housekeeping.enabled gate.

Changes

• AbstractPurgeCommand.deleteEverything() — Set inPurge = true before dispatching the async delete. Clear it in the main-thread callback's finally block (covers both success and failure paths), and in a catch (RuntimeException) guard for synchronous exceptions before the task is dispatched.

• HousekeepingManager.runDeleteIfNonEmpty() — Returns -1 on delete error (previously 0, indistinguishable from "nothing to purge").

• HousekeepingManager.executeAgeCycle() / executeDeletedCycle() — Track boolean hasErrors across all worlds; only advance lastAgeRunMillis / lastDeletedRunMillis and persist state when the full cycle completes error-free. Logs an explicit error and leaves the timestamp unchanged on partial failure so the scheduler retries.

• HousekeepingManager Javadoc — Replaced the incorrect housekeeping.enabled flag reference with accurate references to Settings#isHousekeepingAgeEnabled() and Settings#isHousekeepingDeletedEnabled().

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• repo.momirealms.net
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -XX:MaxMetaspaceSize=384m -XX:+HeapDumpOnOutOfMemoryError -Xms256m -Xmx512m -Dfile.encoding=UTF-8 -Duser.country (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
61.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud