Refactor built-in reward implementations into dedicated classes - #286
Merged
Conversation
BenCodez
marked this pull request as ready for review
August 23, 2026 16:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract AdvancedCore's built-in reward and requirement implementations out of
RewardHandlerinto dedicated implementation classes undercom.bencodez.advancedcore.rewards.builtin.The public extension API under
api.rewards.injectedandapi.rewards.injectedrequirementremains in place and is not moved.Structure
rewards/builtin/RewardExp.javaowns EXP and EXPLevels built-in formsrewards/builtin/RewardMoney.javaowns fixed and ranged money formsrewards/builtin/requirements/contains built-in requirement implementations such as permission, chance, world, server, date, and JavaScriptBuiltinRewardsandBuiltinRequirementsprovide central registrationThis is intended as a behavior-preserving code-organization refactor; reward configuration paths and public inject API types are kept compatible.