fix out-of-bounds read in isBlackboardPointer whitespace trim#1161
Open
aysha-afrah26 wants to merge 1 commit into
Open
fix out-of-bounds read in isBlackboardPointer whitespace trim#1161aysha-afrah26 wants to merge 1 commit into
aysha-afrah26 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isBlackboardPointer trims leading and trailing spaces with two while loops before it checks for the {...} pattern, and each loop tests the character before it tests the index against the bounds. Because of the short-circuit order, str[front_index] is read first and front_index <= last_index only after. When the whole value is spaces, front_index walks up to str.size() and the loop reads one element past the end before the bounds check would have stopped it. The argument is a std::string_view, so that trailing byte is not guaranteed to be there; I ran into it under AddressSanitizer, which reports a heap-buffer-overflow read on a non null-terminated view of three spaces. Swapping the two operands so the bounds check runs first closes the read and leaves the trimming behavior unchanged. I added a regression test in gtest_ports that fails under ASan before the change and passes after.