Fix build with Apple libc++ lacking floating-point std::from_chars#1160
Open
daeho-ro wants to merge 1 commit into
Open
Fix build with Apple libc++ lacking floating-point std::from_chars#1160daeho-ro wants to merge 1 commit into
daeho-ro wants to merge 1 commit into
Conversation
The double branch of the XML attribute parser called std::from_chars unconditionally. Apple's libc++ ships integer from_chars but deletes the floating-point overload (and undefines __cpp_lib_to_chars), so this fails to compile on macOS. Guard it like the other numeric conversions and fall back to std::stod under the "C" locale, keeping the strict full-string validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple's libc++ deletes floating-point
std::from_chars(and undefines__cpp_lib_to_chars), so the unguardeddoubleparse inxml_parsing.cppfails to compile on macOS.
Guard it like the other numeric conversions and fall back to
std::stod,keeping the strict full-string validation. Backward-compatible; compile-only
fix (no unit test).