Remove tinyxml2 vendor on rolling#1135
Conversation
|
It looks like the issue is also due to rolling moved to Ubuntu Resolute, this causes issue when running rosdep on Noble. But I still think this PR is useful, since tinyxml2_vendor is expected to be removed in the future (if I remember correctly, around the Lyrical release) |
|
rolling CI is still failing |
I think there's something wrong with industrial ci and we might need to wait a few more weeks |
| matrix: | ||
| env: | ||
| - {ROS_DISTRO: rolling, ROS_REPO: main} | ||
| - {ROS_DISTRO: rolling, ROS_REPO: testing} |
There was a problem hiding this comment.
I just noticed that the ROS PMC is considering dropping support for the main repository in favor of the testing repository only for Rolling. The CI was failing earlier because there were no syncs for Rolling on 26.04, switching to the testing repo fixed it. Thoughts on this change? @facontidavide
Related:
|
@facontidavide does the changes here make sense to you? If yes, can we merge this and cut a new release, please? |
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
The tinyxml2 rosdep key resolves on every supported distro, and the previous package.xml already declared it directly. Only tinyxml2_vendor needs to be conditional on the distros that still ship it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
a1c2c78 to
ce553fc
Compare
|
@mini-1235 thanks for the fix and for your patience — I took over the branch to get it ready for merging (I force-pushed to your What changed:
I also verified this locally on ROS Lyrical, where Will merge once CI is green, and a release will follow. |
In Nav2, we are building BT.CPP from source temporarily, however, we are failing to build now:
I believe this is because tinyxml2_vendor is deprecated and removed on rolling, so I am removing this in rolling.
ref: https://github.com/open-planning/roboplan/blob/6987faf083d5b097b4251f8f698a1a7832c3ac86/roboplan/package.xml#L15-L16