docs(localization): fix outdated path in translate-help text#781
Merged
docs(localization): fix outdated path in translate-help text#781
Conversation
The "Please help us translate!" panel in General Settings still pointed contributors at StreamingAssets/Basis/Languages, which no longer exists. Update the path in all 18 language files to the current location (Packages/com.basis.framework/BasisUI/Localization/Languages) and rewrite the English description with clearer steps (rename copy to locale code, where to open the PR). Other locales keep their existing translation, with only the literal path swapped — the path was untranslated in every file, so the surrounding sentence stays valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Please help us translate! panel in General Settings (rendered by
SettingsProvider.BuildLanguageSelectorinBasis/Packages/com.basis.framework/BasisUI/Menus/Main Menu Providers/SettingsProvider.cs) was telling contributors to look inStreamingAssets/Basis/Languages. That folder no longer exists — the language files moved into the framework package and are now loaded via Addressables.Changes
StreamingAssets/Basis/LanguageswithPackages/com.basis.framework/BasisUI/Localization/Languages. The path was left untranslated in every locale, so swapping just the substring keeps each existing translation intact.en.json— additionally rewrite the description with clearer steps: rename the copy to your locale code (e.g.fr.json/ja.json) and open the PR atgithub.com/BasisVR/Basis.What I did NOT change
SettingsProvider.csneeds no edit."Please help us translate!"/ equivalents) is unchanged in every language to avoid pointless retranslation churn.Follow-ups for whoever merges