Skip to content

docs(localization): fix outdated path in translate-help text#781

Merged
dooly123 merged 1 commit intodeveloperfrom
docs/translation-help-text-update
Apr 24, 2026
Merged

docs(localization): fix outdated path in translate-help text#781
dooly123 merged 1 commit intodeveloperfrom
docs/translation-help-text-update

Conversation

@dooly123
Copy link
Copy Markdown
Collaborator

What

The Please help us translate! panel in General Settings (rendered by SettingsProvider.BuildLanguageSelector in Basis/Packages/com.basis.framework/BasisUI/Menus/Main Menu Providers/SettingsProvider.cs) was telling contributors to look in StreamingAssets/Basis/Languages. That folder no longer exists — the language files moved into the framework package and are now loaded via Addressables.

Changes

  • All 18 locale JSONs — replace the literal path StreamingAssets/Basis/Languages with Packages/com.basis.framework/BasisUI/Localization/Languages. The path was left untranslated in every locale, so swapping just the substring keeps each existing translation intact.
  • en.json — additionally rewrite the description with clearer steps: rename the copy to your locale code (e.g. fr.json / ja.json) and open the PR at github.com/BasisVR/Basis.

What I did NOT change

  • Localization keys are unchanged, so SettingsProvider.cs needs no edit.
  • The title ("Please help us translate!" / equivalents) is unchanged in every language to avoid pointless retranslation churn.

Follow-ups for whoever merges

  • The Languages addressable group probably needs a rebuild so the updated text ships in built players. Editor playmode picks it up directly from the package.
  • The 17 non-English description strings are now slightly out of sync with English (they don't yet mention the locale-code rename or the GitHub URL). That's a translator-friendly nudge, not a blocker — the path is correct and the original instruction still works.

The "Please help us translate!" panel in General Settings still pointed
contributors at StreamingAssets/Basis/Languages, which no longer exists.
Update the path in all 18 language files to the current location
(Packages/com.basis.framework/BasisUI/Localization/Languages) and rewrite
the English description with clearer steps (rename copy to locale code,
where to open the PR). Other locales keep their existing translation,
with only the literal path swapped — the path was untranslated in every
file, so the surrounding sentence stays valid.
@dooly123 dooly123 merged commit f07d8bd into developer Apr 24, 2026
20 checks passed
@dooly123 dooly123 deleted the docs/translation-help-text-update branch April 24, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant