Fix bounds calculation for skinned meshes#780
Open
art0007i wants to merge 1 commit intoBasisVR:developerfrom
Open
Fix bounds calculation for skinned meshes#780art0007i wants to merge 1 commit intoBasisVR:developerfrom
art0007i wants to merge 1 commit intoBasisVR:developerfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #774
basically the old approach assumes that
smr.localBoundsis local to the transform that the smr is attached to, but in reality it's local tosmr.rootBone. anyway in this PR I decided to just transform the global bounds directly into parent space, this way it's harder to make such mistake, since unity gives you the correct global bounds.