permission_handler_windows: lazily create Geolocator#1546
Open
skylartaylor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
permission_handler_windowscurrently creates a WindowsGeolocatorand subscribes toPositionChangedwhile the plugin is registering. That can make apps appear to access location even when they only depend onpermission_handlerand never request location.This PR removes the eager
Geolocatormember andPositionChangedsubscription.Geolocatoris now created only insideIsLocationServiceEnabled(), so location service-status checks still work without touching the Windows location API during plugin registration.Fixes #983.
Fixes #1394.
Related to #1470 and #1389.
Verification performed:
flutter pub getinpermission_handler_windowsdart format --set-exit-if-changed .inpermission_handler_windowsflutter analyzeinpermission_handler_windowsflutter analyzeinpermission_handler_windows/exampleflutter testinpermission_handler_windowsreports notest/directory, so there is no package test suite for this change0before launch,0after launch)prism_plurality.exe, and location registry entries stayed unchanged (1before launch,1after launch)Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR does not need version changes.CHANGELOG.mdto add a description of the change.///), or this PR does not need documentation changes.main.dart format .and committed any changes.flutter analyzeand fixed any errors.